Add integer and boolean data types for the custom fields #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce new conditions for ParentPrefixSelector Add new custom fields and prefixes for testing ParentPrefixSelector
Signed-off-by: Hoanganh.Mai <hoanganh.mai@swisscom.com> Signed-off-by: Chun-Hung Tseng <chun-hung.tseng@swisscom.com>
Add unit test for restoration hash backward compatibility Support multiple custom field in a query Improve CRD validation to reject having both ParentPrefix and ParentPrefixSelector Reorder column sequence for PrefixClaim Update kustomization.yaml Notes: According to [2], the `oneOf` validation will only come in the next version Reference: [1] https://kubernetes.io/blog/2022/09/29/enforce-immutability-using-cel/ [2] https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#validation-ratcheting Signed-off-by: Hoanganh.Mai <hoanganh.mai@swisscom.com> Signed-off-by: Chun-Hung Tseng <chun-hung.tseng@swisscom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding 2 data types for the custom fields to validate the PrefixClaim can operate with string, integer, and boolean data types.