Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integer and boolean data types for the custom fields #121

Conversation

henrybear327
Copy link
Collaborator

Adding 2 data types for the custom fields to validate the PrefixClaim can operate with string, integer, and boolean data types.

Introduce new conditions for ParentPrefixSelector
Add new custom fields and prefixes for testing ParentPrefixSelector
Signed-off-by: Hoanganh.Mai <hoanganh.mai@swisscom.com>
Signed-off-by: Chun-Hung Tseng <chun-hung.tseng@swisscom.com>
Add unit test for restoration hash backward compatibility
Support multiple custom field in a query
Improve CRD validation to reject having both ParentPrefix and ParentPrefixSelector
Reorder column sequence for PrefixClaim
Update kustomization.yaml

Notes:
According to [2], the `oneOf` validation will only come in the next version

Reference:
[1] https://kubernetes.io/blog/2022/09/29/enforce-immutability-using-cel/
[2] https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#validation-ratcheting

Signed-off-by: Hoanganh.Mai <hoanganh.mai@swisscom.com>
Signed-off-by: Chun-Hung Tseng <chun-hung.tseng@swisscom.com>
@henrybear327 henrybear327 self-assigned this Nov 8, 2024
@henrybear327 henrybear327 marked this pull request as draft November 8, 2024 08:30
@henrybear327 henrybear327 deleted the exp/custom_data_type_query branch November 11, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant